ConfigRawParams: When setting a parameter changes the number of parameters, do a full refresh. and check if reboot is needed #3271
Conversation
EosBandi
changed the title
|
THANKS! I see the build artifact but not sure how to run it locally for some testing....its an aab file? |
CraigElder
changed the title
|
param refresh dangerous when armed, as low bandwidth or long range links can be adversely affected - i support it if its tweaked to only do this when disarmed. |
|
PeterH suggested that we should only do the full refresh when the vehicle is disarmed. |
|
while testing I got this error: Otherwise seems to work well....I agree with Pete's comment re refresh only while disarmed... this PR is really needed!!! thanks |
Indeed, added check for armed state. |
|
@EosBandi will try to reproduce...I was just randomly enablilng/changing parameters that I know need reboots |
If a param change causing the change in the number of parameters, the parameter subsystem could stuck in a "downloading is in progress" state. This pr:
removes the name check, since not only _enable parameters can change the number of parameters
Add a check at the end of Write Params and if the reported param number not equals with the current number, it notify the user and do a param refresh.
This fixes #3198